| From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
|---|---|
| To: | Greg Smith <greg(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Instrument checkpoint sync calls |
| Date: | 2010-11-22 19:27:30 |
| Message-ID: | AANLkTimOw48vy3kznwjQQmGWzCDQp=mVGOO=ZvLJzEy2@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 15, 2010 at 12:09 PM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> So my task list is:
>
> 0) Rebase against the HEAD that just code related to this touched today
>
> 1) Assume that log_checkpoints is sufficient control over whether the timing
> overhead added is worth collecting, and therefore remove the half-baked idea
> of also wrapping with a compile-time option.
>
> 2) Have the sync summary returned upwards, so it can be put onto the same
> line as the rest of the rest of the log_checkpoint info.
>
> All seems reasonable to me. Will rev a new patch by tomorrow.
For the individual file sync times emitted under debug1, it would be
very handy if the file being synced was identified, for example
"relation base/16384/16523". Rather than being numbered sequentially
within a given checkpoint.
Cheers,
Jeff
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-11-22 19:27:43 | Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files) |
| Previous Message | Robert Haas | 2010-11-22 19:24:55 | Re: visibility map |