On Sun, Jun 20, 2010 at 10:51 PM, Steve Singer <ssinger_pg(at)sympatico(dot)ca> wrote:
> One comment I have on the output format is that values (ie the database
> name) are enclosed in double quotes but the values being quoted can contain
> double quotes that are not being escaped. For example
> Connected to database: "testing"er", user: "ssinger", port: "5432" via local
> domain socket
> (where my database name is testing"er ). Programs will have a hard time
> parsing this. I'm not sure if this is a valid concern but I'm mentioning
It seems like for user and database it might be sensible to apply
PQescapeIdentifier to the value before printing it. This will
double-quote it and escape any internal double-quotes appropriately.
The port is, I guess, being stored as a string, but doesn't it have to
be an integer? In which case, why quote it at all?
Is there really a point to the non-DSN format or should we just use
the DSN format always?
The Enterprise Postgres Company
In response to
pgsql-hackers by date
|Next:||From: Ron Mayer||Date: 2010-06-21 04:20:33|
|Subject: Re: Keepalive for max_standby_delay|
|Previous:||From: Robert Haas||Date: 2010-06-21 03:54:21|
|Subject: Re: beta3 & the open items list|