From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org> |
Subject: | Re: wip: functions median and percentile |
Date: | 2010-09-22 04:36:24 |
Message-ID: | AANLkTimLwLdfMvQcfTUGHA65ixsPKb9J4dgppAyVyXDe@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-rrreviewers |
2010/9/22 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> 2010/9/22 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>> 2010/9/21 Robert Haas <robertmhaas(at)gmail(dot)com>:
>>> On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>>>> * Cosmetic coding style should be more appropriate, including trailing
>>>>> white spaces and indentation positions.
>>>>
>>>> can you specify where, please?
>>>
>>> I noticed a lot of problems in this area when working on your \ef /
>>> \sf patch, too. Trailing whitespace is nearly always bad, and it's
>>> not hard to find - just grep the diff for it. As for indentation, try
>>> to match the surrounding code.
>>
>> is updated patch better?
>
> Better, but you should be more careful, for example,
>
> + tuplesort_performsort(aggstate->sortstate);
> + <-- 1
> + while (tuplesort_getdatum(aggstate->sortstate,
> + true,
> + &value, &isNull))
>
> For #1, please remove horizontal tabs in empty lines.
ok, checked removed
Pavel
>
> Regards,
>
>
> --
> Hitoshi Harada
>
Attachment | Content-Type | Size |
---|---|---|
median.diff | text/x-patch | 11.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jesper Krogh | 2010-09-22 04:41:01 | Re: Make tuples_per_page pr. table configureable. |
Previous Message | A.M. | 2010-09-22 03:53:13 | Re: Multi-branch committing in git, revisited |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2010-09-22 04:44:58 | Re: wip: functions median and percentile |
Previous Message | Hitoshi Harada | 2010-09-22 03:06:51 | Re: wip: functions median and percentile |