Skip site navigation (1) Skip section navigation (2)

Re: wip: functions median and percentile

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org>
Subject: Re: wip: functions median and percentile
Date: 2010-09-22 04:36:24
Message-ID: AANLkTimLwLdfMvQcfTUGHA65ixsPKb9J4dgppAyVyXDe@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-rrreviewers
2010/9/22 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> 2010/9/22 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>> 2010/9/21 Robert Haas <robertmhaas(at)gmail(dot)com>:
>>> On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>>>> * Cosmetic coding style should be more appropriate, including trailing
>>>>> white spaces and indentation positions.
>>>>
>>>> can you specify where, please?
>>>
>>> I noticed a lot of problems in this area when working on your \ef /
>>> \sf patch, too.  Trailing whitespace is nearly always bad, and it's
>>> not hard to find - just grep the diff for it.  As for indentation, try
>>> to match the surrounding code.
>>
>> is updated patch better?
>
> Better, but you should be more careful, for example,
>
> +               tuplesort_performsort(aggstate->sortstate);
> +               <-- 1
> +               while (tuplesort_getdatum(aggstate->sortstate,
> +                                                               true,
> +                                                                     &value, &isNull))
>
> For #1, please remove horizontal tabs in empty lines.

ok, checked removed

Pavel
>
> Regards,
>
>
> --
> Hitoshi Harada
>

Attachment: median.diff
Description: text/x-patch (11.9 KB)

In response to

pgsql-hackers by date

Next:From: Jesper KroghDate: 2010-09-22 04:41:01
Subject: Re: Make tuples_per_page pr. table configureable.
Previous:From: A.M.Date: 2010-09-22 03:53:13
Subject: Re: Multi-branch committing in git, revisited

pgsql-rrreviewers by date

Next:From: Pavel StehuleDate: 2010-09-22 04:44:58
Subject: Re: wip: functions median and percentile
Previous:From: Hitoshi HaradaDate: 2010-09-22 03:06:51
Subject: Re: wip: functions median and percentile

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group