| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "Murray S(dot) Kucherawy" <msk(at)cloudmark(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #5837: PQstatus() fails to report lost connection |
| Date: | 2011-01-24 11:55:10 |
| Message-ID: | AANLkTimDRAO_xe4h=vL2j0rdGF3_u2uTk0OHmv2rZK+=@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Jan 24, 2011 at 12:59 AM, Murray S. Kucherawy <msk(at)cloudmark(dot)com> wrote:
> Well my other suggestion would be to assume PGRES_FATAL_ERROR always means the connection needs to be reset. But this blows that idea away; this would cause a connection reset that wouldn't actually solve the problem when it's an ERROR as you described.
Well, actually it's the other way around: resetting the connection
would *work* in the case of an ERROR, but it'd be overkill. Most of
the things that can go wrong are ERROR rather than FATAL, and you just
issue a ROLLBACK to balance out any BEGIN you previously issued, and
then do whatever it is you want to do next. A full connection reset
would be pretty expensive in this context and, as you might guess,
there are a lot more things that cause ERROR than there are that cause
FATAL.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xiaobo Gu | 2011-01-24 14:02:09 | Re: Is there a way to build PostgreSQL client libraries with MinGW |
| Previous Message | Andrew Dunstan | 2011-01-24 09:19:40 | Re: Is there a way to build PostgreSQL client libraries with MinGW |