Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] reviewers needed!

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andy Colson <andy(at)squeakycode(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: [HACKERS] reviewers needed!
Date: 2011-01-16 22:10:49
Message-ID: AANLkTim4yUSJEiC2QoO38GM7gTXjR-v5qPe+umhs2XLb@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-rrreviewers
On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson <andy(at)squeakycode(dot)net> wrote:
> I reviewed a couple patched, and I added my review to the commitfest page.
>
> If I find a problem, its obvious I should mark the patch as "returned with
> feedback".

Only if it's got sufficiently serious flaws that getting it committed
during this CommitFest is not practical.  If it just needs some
revision, "Waiting on Author" is the right place.

> But what if I'm happy with it?  I'm not a hacker so cannot do C code review,
> should I leave it alone?  Mark it as "ready for committer"?

Yep, that's fine.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2011-01-16 22:13:23
Subject: Re: limiting hint bit I/O
Previous:From: Noah MischDate: 2011-01-16 21:38:38
Subject: Re: ALTER TYPE 0: Introduction; test cases

pgsql-rrreviewers by date

Next:From: Richard BroersmaDate: 2011-01-24 20:17:16
Subject: Seeking Mentors for Funded Reviewers
Previous:From: Euler Taveira de OliveiraDate: 2011-01-16 21:13:30
Subject: Re: [HACKERS] reviewers needed!

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group