On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson <andy(at)squeakycode(dot)net> wrote:
> I reviewed a couple patched, and I added my review to the commitfest page.
> If I find a problem, its obvious I should mark the patch as "returned with
Only if it's got sufficiently serious flaws that getting it committed
during this CommitFest is not practical. If it just needs some
revision, "Waiting on Author" is the right place.
> But what if I'm happy with it? I'm not a hacker so cannot do C code review,
> should I leave it alone? Mark it as "ready for committer"?
Yep, that's fine.
The Enterprise PostgreSQL Company
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2011-01-16 22:13:23|
|Subject: Re: limiting hint bit I/O|
|Previous:||From: Noah Misch||Date: 2011-01-16 21:38:38|
|Subject: Re: ALTER TYPE 0: Introduction; test cases|
pgsql-rrreviewers by date
|Next:||From: Richard Broersma||Date: 2011-01-24 20:17:16|
|Subject: Seeking Mentors for Funded Reviewers|
|Previous:||From: Euler Taveira de Oliveira||Date: 2011-01-16 21:13:30|
|Subject: Re: [HACKERS] reviewers needed!|