On Sun, Jul 25, 2010 at 11:42 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> I'm setting this as ready for committer.
> Thank you very much
I took a look at this tonight and am a bit mystified by the following bit:
+ * PL doesn't calculate first row of function's body
+ * when first row is empty. So checks first row, and
+ * correct lineno when it is necessary.
Is that true of any PL, or just some particular PL? Is the behavior
described here a bug that we should fix, or is it, for some reason,
considered correct? Is it documented in our documentation?
The implementation of first_row_is_empty() looks pretty kludgey, too.
It seems to me that it will fail completely if the text of the
function definition happens to contain $function$.
CREATE OR REPLACE FUNCTION boom() RETURNS text LANGUAGE plpgsql AS $$
BEGIN SELECT '$function$'; END $$;
The Enterprise Postgres Company
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2010-08-01 02:31:47|
|Subject: Re: rbtree code breaks GIN's adherence to maintenance_work_mem |
|Previous:||From: Robert Haas||Date: 2010-08-01 01:48:05|
|Subject: Re: ANALYZE versus expression indexes with nondefault opckeytype|