Skip site navigation (1) Skip section navigation (2)

Re: Bug in autovacuum.c?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in autovacuum.c?
Date: 2011-03-31 20:21:50
Message-ID: AANLkTim+h0pnzvqzhEHqYNYWqG=P1-iw907A57YoO-d_@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Mar 31, 2011 at 4:16 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Robert Haas wrote:
>> On Thu, Mar 31, 2011 at 2:59 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> > Bruce Momjian wrote:
>> >> > Yeah, I think this change would have the effect of moving the freeze
>> >> > limit by one (or two?) counts. ?Given the moving nature of values
>> >> > returned by ReadNewTransactionId this would probably have no practical
>> >> > effect. ?Still, the code as is seems more natural to me (Tom wrote this
>> >> > bit IIRC, not me).
>> >>
>> >> I am now thinking the code is correct --- it maps values from 0 to
>> >> FirstNormalTransactionId into the top of the (unsigned) xid range.
>> >> Unless someone objects, I will add a C comment about this behavior so
>> >> future readers are not confused.
>> >
>> > OK, now I think it is wrong. ? :-)
>> >
>> > The effect is to map max xid + 1 to max xid -
>> > FirstNormalTransactionId(3) + 1, which makes the xid look like it is
>> > going backwards, less than max xid --- not good.
>>
>> The XID space is *circular*.
>
> Right but you would think that as the xid moves forward, the caculation
> of how far back to vacuum should move only forward.  In this case,
> incrementing the xid by one would cause the vacuum horizon to move
> backward by two.

I don't see how that would happen.   The XID immediately preceding
FirstNormalTransactionId is 2^32-1, and that's exactly what this
calculation produces.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2011-03-31 20:27:54
Subject: cast from integer to money
Previous:From: Bruce MomjianDate: 2011-03-31 20:18:10
Subject: Re: Problem with pg_upgrade?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group