Skip site navigation (1) Skip section navigation (2)

Re: 64-bit pgbench V2

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Greg Smith <greg(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 64-bit pgbench V2
Date: 2010-07-06 15:03:24
Message-ID: AANLkTilfU2ZxPo_YdspkDDz2ENM8Yh5PGOUHLqtN8TBo@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, Jul 6, 2010 at 11:01 AM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> Robert Haas wrote:
>>
>> It doesn't seem very palatable to have multiple handwritten integer
>> parsers floating around the code base either.  Maybe we should try to
>> standardize something and ship it in src/port, or somesuch
>
> I was considering at one point making two trips through strtol, each allowed
> to gobble 10 characters, then combining the two--just to cut down a little
> bit on the roll your own parser aspects here.  I hadn't really considered
> how the main server does this job though.  If there's something reasonable
> to expose by refactoring some code that's already there, I could take a stab
> at that.  I'm not exactly sure where the integer parsing code in the server
> that would be appropriate is to break out is at though.

Take a look at int8in.  It's got some backend-specific stuff in it ATM
but maybe it would be reasonable to try to fact that out somehow.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2010-07-06 15:03:45
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Greg SmithDate: 2010-07-06 15:01:36
Subject: Re: 64-bit pgbench V2

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group