Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Date: 2010-07-08 16:06:57
Message-ID: AANLkTil2kdneCBfQfqUSQB2wWzMj1tnsln1Nw3puBGPq@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Thu, Jul 8, 2010 at 17:45, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> Tom Lane wrote:
>>
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>
>>>
>>> Seems pretty simple - mingw doesn't have support for this. We have two
>>> ways to deal with that I think:
>>> 1) Disable it on mingw.
>>> 2) Include it in our custom headers.
>>>
>>
>>
>>>
>>> For #2, what we need to include is the define of SIO_KEEPALIVE_VALS as
>>> well as the definition of struct tcp_keepalive.
>>>
>>
>>
>>>
>>> We've done #2 before at least once, which worked well until mingw
>>> suddenly caught up and added it a while later. It's not like this is a
>>> new definition in windows, but we need to be ready for them to
>>> eventually do that.
>>>
>>
>> Yeah.  I'm satisfied with doing #1 and waiting for them to fix it.
>>
>>
>>>
>>> I guess there is:
>>> 3) write an autoconf test and provide them only when mingw doesn't have
>>> it.
>>> if we're going with #3, I'll respectfully have to ask somebod yelse to
>>> write the autoconf test, that's beyond me I think :-)
>>>
>>
>> An easy approximation would be to make the code #ifdef SIO_KEEPALIVE_VALS.
>> That would fail if the mingw guys decide to provide the #define without
>> adding the struct at the same time, but that seems moderately unlikely.
>>
>>
>>
>
> +1 for this course of action.

Here's what I came up with and will apply as soon as my msvc build
completes. (the mingw one works with this)

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachment: mingwkeepalives.patch
Description: application/octet-stream (3.0 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-08 16:09:39
Subject: Re: Out of date comment in xlogutils.c
Previous:From: Joshua TolleyDate: 2010-07-08 16:01:22
Subject: Out of date comment in xlogutils.c

pgsql-committers by date

Next:From: Tom LaneDate: 2010-07-08 16:08:30
Subject: pgsql: Update obsolete comment.
Previous:From: Andrew DunstanDate: 2010-07-08 15:45:41
Subject: Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group