Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date: 2010-12-11 16:44:53
Message-ID: AANLkTikwqUfqPJA3aCpOYB700xYxxm-EBMviU5izaD97@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Dec 11, 2010 at 17:38, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Sat, Dec 11, 2010 at 17:23, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I think the reason it's not failing is that it includes <fcntl.h>.
>
>> S_IRWXU is defined in port/win32.h...
>
> No, it isn't.  There's an apparently-useless definition of _S_IRWXU
> there, but no S_IRWXU.

Hmm. You're right, of course.

A search on my windows box finds the text string S_IRWXU in the
following "*.h" files across the whole filesystem:
c:\perl\lib\CORE\perl.h
c:\perl64\lib\CORE\perl.h
c:\pgsql\src\include\pg_config_os.h
c:\pgsql\src\include\port\win32.h

that's it.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-12-11 16:55:19 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Previous Message Tom Lane 2010-12-11 16:38:26 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-12-11 16:55:04 Re: proposal: auxiliary functions for record type
Previous Message Tom Lane 2010-12-11 16:38:26 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags