Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date: 2010-07-06 14:21:06
Message-ID: AANLkTiktpCf1QXBCwTUfoXYXokwUYf5Yx3FWaIVjTzLO@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Fri, Jun 25, 2010 at 1:56 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
>
>>> Shouldn't this be backpatched, or was this a new bug in 9.0?
>
> We've always output bytes.  I'd have noticed the discrepancy myself if I'd
> read the actual docs ;-)
>
> KB would be more useful.  And I don't think people have enough scripts built
> on this yet to make this break anything.  We should backport to 8.4.

log_temp_files was introduced in 8.3, so we'll need to backpatch this
to 8.3, not just 8.4.  Greg Smith tells me Simon has been busy with
other things, so I'm going to pick this up.  Barring objections, I'm
going to revert Simon's patch and change the behavior instead, per the
attached patch.  I will also back-patch the fix to 8.4 and 8.3.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

Attachment: log_temp_files.patch
Description: application/octet-stream (1.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-06 14:33:18
Subject: Re: Bug? Concurrent COMMENT ON and DROP object
Previous:From: Robert HaasDate: 2010-07-06 14:08:21
Subject: Re: t_self as system column

pgsql-committers by date

Next:From: Tom LaneDate: 2010-07-06 14:42:16
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Tom LaneDate: 2010-07-06 03:55:33
Subject: pgsql: Still more third thoughts: when linking shared libraries, LDFLAGS

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group