Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token

From: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token
Date: 2011-03-12 20:22:38
Message-ID: AANLkTikssDTo4+s9bKn6jTLHtiQFgaUiGj1kvrSe44ui@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On 12 March 2011 19:13, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
> Maybe a stupid question but what is the ! in the variable name
> (ex_hash_setop_except_png!_data)?

There's no good reason. It isn't a valid identifier name.

Whatever preprocessor generates ex_hash_setop_except.pngc and other
files like it is broken.

Take a look at this code, at line 205 of same, that clearly illustrates this:

static wxIcon *ex_hash_setop_except_png!_ico()
{
static wxIcon *ico_ex_hash_setop_except_png!;
if (!ico_ex_hash_setop_except_png! || !ico_ex_hash_setop_except_png!->IsOk())
{
ico_ex_hash_setop_except_png! = new wxIcon();
ico_ex_hash_setop_except_png!->CopyFromBitmap(*ex_hash_setop_except_png!_bmp);
}
return ico_ex_hash_setop_except_png!;
}

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin Trac 2011-03-13 00:38:31 Re: [pgAdmin III] #301: Support for Basic Recovery Control functions for use in Hot Standby
Previous Message Guillaume Lelarge 2011-03-12 19:13:03 Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token