Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

From: Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date: 2010-07-08 00:32:12
Message-ID: AANLkTiko1gnFwc9iczgeOa8XPzh7AwNJZEyxtCQts7tA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
2010/7/8 Josh Berkus <josh(at)agliodbs(dot)com>:
> On 7/6/10 8:06 AM, Tom Lane wrote:
>> It might be that nobody's using any values other than 0 and -1 ...
>> in which case it wouldn't matter anyway.  I agree that the lack of
>> bug reports is notable.  But still, don't we try to avoid behavioral
>> changes in stable branches?
>
> I think most people are doing what I was doing: looking at the values in
> the logs, and writing math appropriately.  Most of the other log output
> isn't documented well, and the output values are obviously bytes, so
> frankly it never occurred to me to check the docs.

Samething here

>
> Agreed that backporting the fix to 8.3 and 8.4 is infeasible.

+1
But I don't understand why not backport a documentation patch. Thing
is identified, clearly boring for one just trusting the docs.

>
> --
>                                  -- Josh Berkus
>                                     PostgreSQL Experts Inc.
>                                     http://www.pgexperts.com
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>



-- 
Cédric Villemain               2ndQuadrant
http://2ndQuadrant.fr/     PostgreSQL : Expertise, Formation et Support

In response to

pgsql-hackers by date

Next:From: Cédric VillemainDate: 2010-07-08 01:04:07
Subject: Re: ALTER TABLE SET STATISTICS requires AccessExclusiveLock
Previous:From: Tom LaneDate: 2010-07-08 00:29:43
Subject: Re: Bug? Concurrent COMMENT ON and DROP object

pgsql-committers by date

Next:From: Magnus HaganderDate: 2010-07-08 10:20:14
Subject: pgsql: Add support for TCP keepalives on Windows, both for backend and
Previous:From: Tom LaneDate: 2010-07-08 00:14:41
Subject: pgsql: Fix "cannot handle unplanned sub-select" error that can occur

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group