Skip site navigation (1) Skip section navigation (2)

Re: pgAdmin III commit: Revert the previous change that introduced sysSetti

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org, Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Date: 2011-02-17 11:33:27
Message-ID: AANLkTikntcE_v1usNy6MFTVFvJpPEVkW7mNQwerc5Va9@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Peter;

Just so you're aware of this...

On Thu, Feb 17, 2011 at 11:31 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Revert the previous change that introduced sysSettings::WriteBool(),
> and restore the previous Write() overload. Whilst the change was, in
> theory, good, it failed to take into account that users of previous
> versions of pgAdmin would have true/false values stored in the
> Windows registry as REG_SZ values of "true" or "false", not REG_DWORDs
> as the new code would write. Needs more thought, and thorough testing
> on Windows when we re-visit this.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=aedd49e2b7bfd3104b5a9f30a4e70c0ea2892170
>
> Modified Files
> --------------
> pgadmin/include/utils/sysSettings.h |    6 +++++-
> pgadmin/utils/sysSettings.cpp       |   11 ++++++-----
> 2 files changed, 11 insertions(+), 6 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Peter GeogheganDate: 2011-02-17 13:14:48
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Previous:From: Dave PageDate: 2011-02-17 11:31:30
Subject: pgAdmin III commit: Revert the previous change that introducedsysSetti

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group