Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date: 2010-07-06 15:05:06
Message-ID: AANLkTikgPQHms_mcuHkbob_bGSJFsqaJYLDCC8dNnUEg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Jul 6, 2010 at 11:03 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Robert Haas wrote:
>> I think my least favorite option is changing the behavior only in
>> HEAD.  I think the reasonable options are:
>>
>> 1. Change the behavior in HEAD, 8.4, and 8.3, per previous discussion.
>>  If we do this, we should do what I proposed in my previous email.
>>
>> 2. Change the comments and documentation in 8.4 and 8.3 along the
>> lines that Simon already did in HEAD.  If we do this, we also need to
>> change the GUC units to something other than GUC_UNIT_KB, as noted
>> upthread.  I'm not sure what would be appropriate.
>>
>> The reason I think it's OK to change the behavior in the back-branches
>> is that (a) the only thing it affects is logging, so it shouldn't
>> really "break" anything, and (b) apparently nobody has noticed that
>> the interpretation of the GUC is off by three orders of magnitude, so
>> either nobody's using it or they're not looking at what's actually
>> happening too carefully.  But I'm OK with going the other way and
>> changing the code and docs in the back-branches, too.  I just think we
>> should be consistent.
>
> I normally don't backpatch anything unless it is either a possible cause
> of data loss, or a problem that is reported by multiple people.
>
> Anything backpatched risks causing instability, and might discourage
> people from performing minor upgrades.  Minor fixes are rarely worth the
> risk of causing instability in back-branches.

OK.  Well, in that case, I think we should backpatch the changes Simon
already made, and also pick a new unit for the GUC.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-06 15:06:05
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Bruce MomjianDate: 2010-07-06 15:03:45
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

pgsql-committers by date

Next:From: Tom LaneDate: 2010-07-06 15:06:05
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Bruce MomjianDate: 2010-07-06 15:03:45
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group