Coccinelle found a few places in the code where pointer expressions
were compared to 0. I have changed them to NULL instead.
There was one line that I didn't dare to touch, which looks like a
if (v->now - save == 0 || ((int) c > 0 && (int) c <= v->nsubexp))
I couldn't find the definition of v (struct vars) anywhere. Is it
comparing two pointers here? Should it be "v->now == save" instead?
But this code doesn't originate from PostgreSQL, so maybe it's not
worth making cleanups here.
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2010-10-29 16:53:30|
|Subject: Re: plan time of MASSIVE partitioning ... |
|Previous:||From: Tom Lane||Date: 2010-10-29 15:54:52|
|Subject: Re: crash in plancache with subtransactions |