2011/2/1 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> 2011/2/1 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> writes:
>>> Finally I concluded the concern Itagaki-san raised can be solved by
>>> adding code that restores client_encoding in copy_in_error_callback.
>>
>> It might happen to work today (or at least in the scenarios you tested),
>> but it seems fragile as can be.
>
> Although I thought its fragile-ness was acceptable to avoid making the
> patch too complex, I agree with you.
> The third patch is attached, modifying mb routines so that they can
> receive conversion procedures as FmgrInof * and save the function
> pointer in CopyState.
> I tested it with encoding option and could not see performance slowdown.
>

Hmm, sorry, the patch was wrong. Correct version is attached.

Regards,



-- 
Hitoshi Harada

In response to

• Re: Add ENCODING option to COPY at 2011-02-01 02:16:54 from Hitoshi Harada

Responses

• Re: Add ENCODING option to COPY at 2011-02-04 05:39:59 from Itagaki Takahiro

pgsql-hackers by date

Next:	From: Pavel Stehule	Date: 2011-02-01 04:41:25
	Subject: Re: [pgsql-general 2011-1-21:] Are there any projects interested in object functionality? (+ rule bases)
Previous:	From: Fujii Masao	Date: 2011-02-01 03:45:27
	Subject: Re: Allowing multiple concurrent base backups