Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to
Date: 2010-05-31 10:20:28
Message-ID: AANLkTikW9iROK6G-r1n7_RAmRHhuwmZGR2A-xV8eYZYd@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Mon, May 31, 2010 at 7:03 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> Hi,
>
> On Thu, May 27, 2010 at 7:21 AM, Heikki Linnakangas
> <heikki(at)postgresql(dot)org> wrote:
>> Log Message:
>> -----------
>> In walsender, don't sleep if there's outstanding WAL waiting to be sent,
>> otherwise we effectively rate-limit the streaming as pointed out by
>> Simon Riggs. Also, send the WAL in smaller chunks, to respond to signals
>> more promptly.
>>
>> Modified Files:
>> --------------
>>    pgsql/src/backend/replication:
>>        walsender.c (r1.20 -> r1.21)
>>        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walsender.c?r1=1.20&r2=1.21)
>
> This commit seems to have introduced the bug that walsender exits
> before sending all the WAL up to shutdown checkpoint record when
> smart shutdown is requested.
>
> The attached patch fixes the bug and a tiny typo.

Sorry. I forgot to attach the patch..

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment: send_xlog_upto_shutdown_ckpt_v1.patch
Description: application/octet-stream (979 bytes)

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2010-05-31 10:45:02
Subject: Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to
Previous:From: Fujii MasaoDate: 2010-05-31 10:17:03
Subject: Re: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2010-05-31 10:44:37
Subject: pgsql: Send all outstanding WAL before exiting when smart shutdown is
Previous:From: Fujii MasaoDate: 2010-05-31 10:03:44
Subject: Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group