Re: phase 2 of wxWidgets 2.9 build

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: phase 2 of wxWidgets 2.9 build
Date: 2011-02-11 03:34:49
Message-ID: AANLkTikTZN-jwxXrPXsW5wmxjrHWxq9Pt8SKrjR_9sux@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Feb 11, 2011 at 12:44 AM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
> On 10 February 2011 23:31, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> Can u send me the code from Julian please?
>
> I assume you want me to send you the new, improved OGL from Julian +
> my fixes to make it build against 2.9, which I myself am using . I'll
> send it to you later, because I don't have it at the moment.

Or just what he sent - it didn't take long to fix it up last time. I
see it now though anyway... thanks!

>>> By the way, I missed one of the "(consider omitting number of rows or
>>> columns)" problems on the options dialog earlier. I may have missed
>>> others, but obviously that won't affect 2.8 builds.
>>
>> I don't believe I've had a patch with any of that yet.
>
> You have. Changes look like this:
>
>                 <object class="sizeritem">
>                   <object class="wxFlexGridSizer">
>                     <cols>2</cols>
> -                    <rows>2</rows>
>                     <vgap>5</vgap>
>
> I remove the row per the suggestion of the wx error message. That has
> no apparent effect, other than making the error go away.

I saw your description of the fix, but I didn't see a patch to go with it.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil S 2011-02-11 07:51:03 Re: pgAdmin III: the debugger does not pre-populate default values for arguments
Previous Message Peter Geoghegan 2011-02-10 23:44:38 Re: phase 2 of wxWidgets 2.9 build