Skip site navigation (1) Skip section navigation (2)

Re: wxWidgets 2.9 build

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: wxWidgets 2.9 build
Date: 2011-01-29 09:30:42
Message-ID: AANLkTikSYL4ZGCRu4+CFOGSRn_XpjMPBWSbRqJniym9=@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Wed, Jan 26, 2011 at 6:41 PM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
>
> Attached patch fixes all warnings, and builds against wx 2.8 and 2.9,

Builds fine on my Mac. I wonder, should we use a macro to improve
readability, eg:

#define cstr(x) ((const wxChar *)x)

(can't use c_str - that seems to be in use already on VC++ 2008)

Also, did you change all of the variadic calls? I still see a
wxLogInfo with a .c_str() parameter in pgadmin/db/pgConn.cpp:169 for
example.

On VC++ 2008, I get the following warnings:

Warning	1	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\agent\pgajob.cpp	128
Warning	2	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\frm\frmhint.cpp	363
Warning	3	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\edbprivatesynonym.cpp	70
Warning	4	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgaggregate.cpp	189
Warning	5	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgaggregate.cpp	191
Warning	6	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgaggregate.cpp	193
Warning	7	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgcast.cpp	132
Warning	8	warning C4800: 'const wchar_t *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgforeignkey.cpp	233
Warning	9	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgserver.cpp	991
Warning	10	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgserver.cpp	1047
Warning	11	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgserver.cpp	1050
Warning	12	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgtable.cpp	961
Warning	13	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgtable.cpp	973
Warning	14	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgtable.cpp	1015
Warning	15	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\schema\pgtable.cpp	1044
Warning	16	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\slony\slcluster.cpp	298
Warning	17	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\slony\slcluster.cpp	309
Warning	18	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\slony\slnode.cpp	202
Warning	19	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\slony\slnode.cpp	246
Warning	20	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\slony\slnode.cpp	251
Warning	21	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\utils\syssettings.cpp	612
Warning	22	warning C4800: 'const wxChar *' : forcing value to bool
'true' or 'false' (performance
warning)	c:\users\dpage\documents\pgadmin3\pgadmin\debugger\dlgdirectdbg.cpp	365

> or would were it not for OGL and Flex/Bison issues with 2.9.

Whats the plan with OGL? I think we should get a list of all the
committers to it (excluding the bakefile, which we don't need), and
email them, explaining that Julian has given permission to relicence
the code, and asking if they'll be kind enough to do the same.

Thoughts? Do you want to do that, or should I?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Peter GeogheganDate: 2011-01-29 18:08:03
Subject: Re: wxWidgets 2.9 build
Previous:From: Nikhil SDate: 2011-01-29 08:56:30
Subject: pgAdmin III: Error on clicking "Display Objects" while doing a restore

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group