Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date: 2010-07-06 14:52:48
Message-ID: AANLkTikSRgisR9sEzIZZ28f9yK0r0DuiMGnztjA2gHVG@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Jul 6, 2010 at 10:42 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> log_temp_files was introduced in 8.3, so we'll need to backpatch this
>> to 8.3, not just 8.4.  Greg Smith tells me Simon has been busy with
>> other things, so I'm going to pick this up.  Barring objections, I'm
>> going to revert Simon's patch and change the behavior instead, per the
>> attached patch.  I will also back-patch the fix to 8.4 and 8.3.
>
> I agree with doing this for 9.0, but I'm much less sold that it's a good
> idea to change the meaning of the parameter in minor releases of 8.4 and
> 8.3.  Aren't you risking breaking installations that work now?

I think my least favorite option is changing the behavior only in
HEAD.  I think the reasonable options are:

1. Change the behavior in HEAD, 8.4, and 8.3, per previous discussion.
 If we do this, we should do what I proposed in my previous email.

2. Change the comments and documentation in 8.4 and 8.3 along the
lines that Simon already did in HEAD.  If we do this, we also need to
change the GUC units to something other than GUC_UNIT_KB, as noted
upthread.  I'm not sure what would be appropriate.

The reason I think it's OK to change the behavior in the back-branches
is that (a) the only thing it affects is logging, so it shouldn't
really "break" anything, and (b) apparently nobody has noticed that
the interpretation of the GUC is off by three orders of magnitude, so
either nobody's using it or they're not looking at what's actually
happening too carefully.  But I'm OK with going the other way and
changing the code and docs in the back-branches, too.  I just think we
should be consistent.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgsql-hackers by date

Next:From: Greg SmithDate: 2010-07-06 15:01:36
Subject: Re: 64-bit pgbench V2
Previous:From: Greg SmithDate: 2010-07-06 14:51:56
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

pgsql-committers by date

Next:From: Bruce MomjianDate: 2010-07-06 15:03:45
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Greg SmithDate: 2010-07-06 14:51:56
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group