Skip site navigation (1) Skip section navigation (2)

Re: PATCH: FB#15614: Use CALL for callable statements

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: FB#15614: Use CALL for callable statements
Date: 2010-05-27 10:49:33
Message-ID: AANLkTikORqwosB-W9XPNqCotlKpReFsbJUfZTqhM-lJe@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Thu, May 27, 2010 at 11:20 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 27/05/2010 11:32, Dave Page a écrit :
>> Thanks - patch applied.
>>
>> On Thu, May 27, 2010 at 10:22 AM, Ashesh Vashi
>> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>> Hi Dave,
>>>
>>> Please find the patch for the same.
>>> This is valid for both trunk and REL-1_10 patch.
>>>
>
> Are we sure that the dlgDirectDbg::invokeTargetCallable() method is only
> called when connected to an EDB server? I didn't work a lot with the
> debugger frontend source code, but it seems to me that this function can
> be called even with vanilla PostgreSQL servers, especially on Windows
> (see dlgDirectDbg::invokeTarget() method). Am I wrong?

Hopefully :-)

m_targetInfo->getIsFunction() should return false for anything other
than an EDB-SPL stored procedure:

#ifdef __WXMSW__
    if (!m_targetInfo->getIsFunction() &&
        PQiGetOutResult &&
        PQiPrepareOut &&
        PQiSendQueryPreparedOut)
        invokeTargetCallable();
    else
#else
#ifdef EDB_LIBPQ
    if (!m_targetInfo->getIsFunction())
        invokeTargetCallable();
    else
#endif
#endif



-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-05-27 11:40:03
Subject: Re: PATCH: FB#15614: Use CALL for callable statements
Previous:From: pgAdmin TracDate: 2010-05-27 10:21:59
Subject: Re: [pgAdmin III] #196: Use CALL for callable statements

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group