Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Allow copydir() to be interrupted.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow copydir() to be interrupted.
Date: 2010-07-02 13:30:06
Message-ID: AANLkTikI-zfu-EmPzVGQb9NrhSL_3L6oHYL06wP-JfcG@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Fri, Jul 2, 2010 at 9:19 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Fri, Jul 2, 2010 at 2:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Jul 2, 2010 at 8:10 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> Robert Haas wrote:
>>>> Log Message:
>>>> -----------
>>>> Allow copydir() to be interrupted.
>>>>
>>>
>>> This appears to have broken MinGW and Cygwin builds on the buildfarm.
>>
>> Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if
>> this is a link-ordering problem of some kind.
>
> We've seen something like this before, but I don't recall what it was.
> It's probably something getting resolved too early when it's built
> into libpgport_srv.a. That would explain why it's working fine on MSVC
> - we don't actually bother building a server-side .lib there, we just
> link the object files directly into postgres.exe. (We do build the
> library for client side, of course, since it's used in many different
> binaries)

I wonder if we should just move copydir.c to someplace within the
backend, perhaps backend/storage/file or backend/utils/misc.  It's
already backend-specific code anyway, so I'm not sure there's much
point in having it in src/port.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-02 14:18:38
Subject: Re: pgsql: Allow copydir() to be interrupted.
Previous:From: Magnus HaganderDate: 2010-07-02 13:19:23
Subject: Re: pgsql: Allow copydir() to be interrupted.

pgsql-committers by date

Next:From: Tom LaneDate: 2010-07-02 14:18:38
Subject: Re: pgsql: Allow copydir() to be interrupted.
Previous:From: Magnus HaganderDate: 2010-07-02 13:19:23
Subject: Re: pgsql: Allow copydir() to be interrupted.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group