Re: Feature: visual feedback of disabled triggers

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: "R(dot)I(dot)K" <r(dot)i(dot)k(at)free(dot)fr>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Feature: visual feedback of disabled triggers
Date: 2011-03-07 04:50:27
Message-ID: AANLkTikCu=1to6Pq29F3nOLLq_XCf4CeFbJV9U4ip7Bw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Sun, Mar 6, 2011 at 3:16 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 09/02/2011 23:11, Guillaume Lelarge a écrit :
>> Le 08/02/2011 07:48, Dave Page a écrit :
>>> On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge
>>> <guillaume(at)lelarge(dot)info> wrote:
>>>> Le 04/02/2011 11:42, R.I.K a écrit :
>>>>> [...]
>>>>> I would like to suggest you a simple feature : is it possible to add, in
>>>>> the left panel of pgAdmin (objects browser), a visual feedback of
>>>>> disabled triggers (like a red cross, for example, or a greyed icon) ?
>>>>>
>>>>
>>>> I think the greyed icon would be best. If we want to do this, we need to
>>>> do this for rules too.
>>>
>>> We use a red cross for disconnected databases. I think it should be
>>> consistent with that.
>>>
>>
>> OK, I added a ticket on that.
>>
>
> Worked on it. Results available in this git branch:
>
> https://github.com/gleu/pgadmin3/tree/ticket306
>
> Patch attached with a screenshot.

The screenshot looks good, as does the patch at a quick glance.

It's going to conflict with the one I'm working on though :-(. Guess
it'll be a race to commit!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Thom Brown 2011-03-07 05:49:28 Re: Support for invalid foreign keys
Previous Message Dave Page 2011-03-07 04:48:00 Re: Support for invalid foreign keys