On Thu, Feb 24, 2011 at 2:52 AM, Peter Geoghegan
> On 23 February 2011 23:51, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> It seems that the wxWidgets guys have fixed the issue with 2.9 on Mac,
>> so I was able to try out a build today. Attached is the patch for your
>> review. Aside from an issue with the font selector dialog (which seems
>> to work OK now, thus the workaround which is broken on 2.9 anyway
>> isn't required), the main issue I see is this:
> Good. How many of the remaining 2.9 bugs that I reported were you able
> to reproduce on the Cocoa build? Did you see:
> * Any distortion of AUI elements, other than the distortion visible in
> toolbar.png .
> * Table editor segfaulting when text and serial datums are edited, but
> not when integer and numeric datums are edited.
I just realised what's probably causing that - we use our own version
of wxGridCellTextEditor, which uses the STC instead of a rich text box
to avoid some bugs. Because we haven't implemented our own version of
EndEdit() yet, it's probably assuming the edit control is the original
type in the default code.
> * Splash screen not displaying.
That's working fine.
> My suspicion is that you won't see most or all of these bugs, because
> they specifically relate to wxGTK-2.9.
>> ./dlg/dlgDatabase.cpp: In member function ‘bool
>> dlgDatabase::executeDDLSql(const wxString&)’:
>> ./dlg/dlgDatabase.cpp:425: error: request for member ‘GetClientData’
>> is ambiguous
>> /usr/local/include/wx-2.9/wx/ctrlsub.h:297: error: candidates are:
>> void* wxItemContainer::GetClientData(unsigned int) const
>> /usr/local/include/wx-2.9/wx/event.h:3204: error:
>> void* wxEvtHandler::GetClientData() const
>> It's easily fixed (albeit somewhat ugly) as can be seen in the patch -
>> but I'm somewhat baffled about why the compiler thinks the two
>> functions listed are both candidates, given that one takes an argument
>> and the other doesn't. Any ideas?
> Yeah, that's fairly ugly. The issue you're experiencing doesn't make
> much sense to me. I've done an SVN update, and am at a commit 20
> minutes before you sent your e-mail. Since I can still build this fine
> against wxGTK-2.9, it stands to reason it's a bug in wxWidgets,
> perhaps down to platform #ifdefs. I would not commit the patch, but
> report the bug.
> I note that this occurs with wxComboBoxs. I don't have time to look at
> the platform specific implementation in detail right now, but I
> suspect the dastardly diamond problem (Do other people call it
> dastardly or is that just me? I can't remember) has occurred, what
> with the extensive use of multiple inheritance. Take a look here:
Will do. I'm actually OOO for the next few days, so I'll try to look
in the evenings.
>> - The toolbars have button labels displayed through them for some
>> reason (see the attached screenshot).
> This may sound silly, but are you sure that just isn't how tooltips
> are supposed to be displayed with Cocoa? The icons are faded/inactive
> at the same time as their tooltips. It looks deliberate. If so, maybe
> you should use an #ifdef to customise the appearance of the toolbar
> tooltips on Cocoa.
I've never seen that effect in any other apps that I can recall. Plus
the toolbars do have a text style to enable/disable labels, which is
off by default.
>> - Highlighting text in the STC has a weird effect on lower parts of
>> the sae window (see the attached screenshot).
> Looks like another upstream WX bug.
Yeah, that was my thought.
>> - The wxDIALOG_MODAL flag seems to be gone.
> indicates that that flag is obsolete, and it's 7 years old. Does the
> absence of the flag have any noticeable behavioural effect? I doubt
> that it does.
Ahh, ok. Didn't get as far as searching for that yet - thanks!
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
In response to
pgadmin-hackers by date
|Next:||From: Dave Page||Date: 2011-02-24 08:36:18|
|Subject: Re: Building with wx2.9 on Mac|
|Previous:||From: Nikhil S||Date: 2011-02-24 03:11:44|
|Subject: Re: pgAdmin III: adjust code as per new EDB AS90