From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <rhaas(at)postgresql(dot)org> |
Subject: | Re: pgsql: Add TCP keepalive support to libpq. |
Date: | 2010-06-25 17:08:31 |
Message-ID: | AANLkTik8ObWrkaggrBTXKWyOLWEgTMepGQ6tD98orZZc@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Jun 25, 2010 at 1:02 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
>> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> Here's an attempt at rewording the sections so that the
>>> information is included in each parameter's description without
>>> taking up a whole sentence.
>>>
>>> Thoughts?
>
>> It makes the point without beating one over the head with it. I
>> particularly like the way this patch moves the main point of the
>> parameter to the front, with all the conditions under which it might
>> be ignored pushed farther back. It reads much better that way, at
>> least for me.
>
> Looks good to me too.
OK, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Berkus | 2010-06-25 17:56:44 | Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes. |
Previous Message | Robert Haas | 2010-06-25 17:08:09 | pgsql: Rewrite docs for new libpq keepalive parameters. |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-06-25 17:33:47 | Admission Control |
Previous Message | Tom Lane | 2010-06-25 17:02:51 | Re: pgsql: Add TCP keepalive support to libpq. |