Re: wxWidgets 2.9 build

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: wxWidgets 2.9 build
Date: 2011-01-26 09:15:59
Message-ID: AANLkTik6X-XJntc6WKPJ2AJ50SVZ=DOD1YR_YHRzpYDv@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jan 25, 2011 at 11:56 PM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
> I had another look at ctlSQLBox::RegexFindText() this evening. I'm
> just going to use the equivalent wx functionality. So, our drop in
> replacement for wx2stc() is:
>
> wxWX2MBbuf ctlSQLBox::StrStc(const wxString& str)
> {
>
> #if wxUSE_UNICODE
>        return str.mb_str(wxConvUTF8);
> #else
>        return str.mbc_str();
> #endif
>
> }
>
> This appears to work fine. Objections?

We don't support non-unicode builds any more, so you might as well
just inline the mb_str call where it's needed, and lose the rest.

Otherwise, no objections :-p

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-01-26 09:34:23 Re: wxWidgets 2.9 build
Previous Message Peter Geoghegan 2011-01-25 23:56:24 Re: wxWidgets 2.9 build