Skip site navigation (1) Skip section navigation (2)

Re: pgindent (was Re: Header comments in the recently added files)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent (was Re: Header comments in the recently added files)
Date: 2011-03-18 16:46:03
Message-ID: AANLkTik6GydB1piB8JGS+6L60RJu8CXpp4KNiiKZkTX7@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Mar 10, 2011 at 11:25 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Mar 10, 2011 at 10:59 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>>>> Speaking of running scripts, I think we should run pgindent now.
>>
>>> Yeah, +1 for doing it as soon as Tom is at a good stopping point.  It
>>> makes things a lot simpler later on.
>>
>> IIRC the argument for an early pgindent run was to standardize the new
>> code for easier review.  I expect to be spending a whole lot of time
>> reading collate and SSI code over the next few weeks, so I'm in favor
>> of pgindent'ing that stuff first.  But I guess we need the typedef
>> list update before anything can happen.
>
> That's one good reason.  Another is that this is presumably the time
> of the cycle when there are the fewest outstanding patches, making it
> a good time for changes that are likely to conflict with lots of other
> things.
>
> At any rate, it sounds like Andrew needs a few days to get the typedef
> list together, so let's wait for that to happen and then we'll see
> where we are.

Andrew, any update on this?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2011-03-18 16:48:57
Subject: Re: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.
Previous:From: Robert HaasDate: 2011-03-18 16:37:44
Subject: Re: Sync Rep and shutdown Re: Sync Rep v19

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group