Skip site navigation (1) Skip section navigation (2)

Re: Ticket 266: Unable to backup table when quotation marks used in the name

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Ticket 266: Unable to backup table when quotation marks used in the name
Date: 2010-11-18 04:25:31
Message-ID: AANLkTik4BAvKgfeojfQ+7g0eFXhX3=2kChs_TtRSHNKY@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Guillaume,

As long as I do remember, the commandLineClenOption() function was
introduced, because of the command-line parameter behaves differently with
quote on different platforms.

Though - I have tested your patch (Sorry - I do not have enough time to
spend around pgAdmin now-a-days because of the work load).
But It will be good - if you can please test the patch on all the platform
(specially on windows) with quote in the name for table, user-name, etc
before applying this patch.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>



*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>


On Thu, Nov 18, 2010 at 4:01 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info>wrote:

> Hi,
>
> I worked on this bug since sunday evening, and it's really an annoying
> one. We have an issue with objects' names containing double quotes when
> doing a backup, whatever your OS is.
>
> I found a fix, and I would usually commit it ASAP. But this time, I'm a
> bit worried. I don't understand why the commandLineCleanOption()
> function (in misc.c) is so complicated. There should be a reason.
> Unfortunately, The fix I wrote deletes almost all of it.
>
> If someone has an explanation of the function, I'm happy to hear it.
>
> And if someone thinks my patch is just plain stupid, tell me before I
> commit it :)
>
> Thanks.
>
>
> --
> Guillaume
>  http://www.postgresql.fr
>  http://dalibo.com
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-11-18 08:08:59
Subject: Re: Ticket 266: Unable to backup table when quotation marks used in the name
Previous:From: Guillaume LelargeDate: 2010-11-17 22:55:31
Subject: Re: pgAdmin III commit: The enum alter query now requires LABEL keyword

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group