Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date: 2010-07-06 15:17:02
Message-ID: AANLkTik3M5dwZY_My9ymiHe96yEr5wzkJ5lFxxrhg5rC@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Jul 6, 2010 at 11:10 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Tue, Jul 6, 2010 at 11:03 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>>> Anything backpatched risks causing instability, and might discourage
>>> people from performing minor upgrades.  Minor fixes are rarely worth the
>>> risk of causing instability in back-branches.
>
>> OK.  Well, in that case, I think we should backpatch the changes Simon
>> already made, and also pick a new unit for the GUC.
>
> Changing the unit setting would also be a behavioral change.  I think
> what Bruce is suggesting is that this is simply not worth worrying about
> in the back branches.

It seems pretty strange not to at least document it.  And I'm not wild
about adding documentation that says "Even though this value purports
to be in kilobytes, it's really not", but I guess we can.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-06 15:25:21
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Tom LaneDate: 2010-07-06 15:10:18
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

pgsql-committers by date

Next:From: Tom LaneDate: 2010-07-06 15:25:21
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Tom LaneDate: 2010-07-06 15:10:18
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group