Re: Drop one-argument string_agg? (was Re: string_agg delimiter having no effect with order by)

From: Merlin Moncure <mmoncure(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alex Hunsaker <badalex(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Drop one-argument string_agg? (was Re: string_agg delimiter having no effect with order by)
Date: 2010-08-04 20:42:30
Message-ID: AANLkTik-svurjPySv=jxG3+uHUi7UsAnJOemD+UJ5_CG@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Aug 4, 2010 at 3:11 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alex Hunsaker <badalex(at)gmail(dot)com> writes:
>> On Wed, Aug 4, 2010 at 11:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> If we were a bit earlier in the 9.0 cycle I would suggest that this
>>> confusion is a sufficient reason to drop the one-argument form of
>>> string_agg. It's too late now though.
>
>> FWIW I think we can still change it.   Isn't this type of issue part
>> of what beta is for?  If we were in RC that would be a different story
>> :)
>
> Well, it'd take an initdb to get rid of it.  In the past we've avoided
> forcing initdb post-beta1 unless it was Really Necessary.  OTOH, we seem
> to be in the mode of encouraging beta testers to test pg_upgrade, so
> maybe that concern isn't worth much at the moment.

I vote fix it. This is going to be a high travel function, and should be right.

merlin

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Hitesh Bhambhani 2010-08-04 21:47:12 BUG #5599: Vacuum fails due to index corruption issues
Previous Message David Fetter 2010-08-04 20:28:13 Re: [HACKERS] Re: Drop one-argument string_agg? (was Re: string_agg delimiter having no effect with order by)

Browse pgsql-hackers by date

  From Date Subject
Next Message Nilson 2010-08-04 21:09:13 Using Small Size SSDs to improve performance?
Previous Message David Fetter 2010-08-04 20:28:13 Re: [HACKERS] Re: Drop one-argument string_agg? (was Re: string_agg delimiter having no effect with order by)