2010/9/22 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
> 2010/9/21 Robert Haas <robertmhaas(at)gmail(dot)com>:
>> On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>>> * Cosmetic coding style should be more appropriate, including trailing
>>>> white spaces and indentation positions.
>>>
>>> can you specify where, please?
>>
>> I noticed a lot of problems in this area when working on your \ef /
>> \sf patch, too.  Trailing whitespace is nearly always bad, and it's
>> not hard to find - just grep the diff for it.  As for indentation, try
>> to match the surrounding code.
>
> is updated patch better?

Better, but you should be more careful, for example,

+ 		tuplesort_performsort(aggstate->sortstate);
+ 		<-- 1
+ 		while (tuplesort_getdatum(aggstate->sortstate,
+ 								true,
+ 								      &value, &isNull))

For #1, please remove horizontal tabs in empty lines.

Regards,


-- 
Hitoshi Harada

In response to

• Re: wip: functions median and percentile at 2010-09-21 21:03:31 from Pavel Stehule

Responses

• Re: wip: functions median and percentile at 2010-09-22 04:36:24 from Pavel Stehule

pgsql-hackers by date

Next:	From: Abhijit Menon-Sen	Date: 2010-09-22 02:32:57
	Subject: Re: repository size differences
Previous:	From: David E. Wheeler	Date: 2010-09-22 02:16:31
	Subject: Re: Multi-branch committing in git, revisited

pgsql-rrreviewers by date

Next:	From: Hitoshi Harada	Date: 2010-09-22 03:06:51
	Subject: Re: wip: functions median and percentile
Previous:	From: Pavel Stehule	Date: 2010-09-21 21:03:31
	Subject: Re: wip: functions median and percentile