Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,
Date: 2011-03-08 10:48:30
Message-ID: AANLkTi=z+eg6yMEtJCqYb0OnGaNMoTg9eYiK-xm8v0AQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Mar 8, 2011 at 12:04 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Feb 9, 2011 at 5:12 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> I was also worried about the non-hot-standby case, but I see that the
>> patch makes sure you can't enable pause when not in hot standby mode.
>> Which in itself might be surprising - perhaps we need a NOTICE for
>> when that happens as well?
>
> I didn't include this fix in the patch because I prefer FATAL to
> NOTICE for that.
> NOTICE doesn't stop recovery. So we might be unable to notice such a NOTICE
> message and stop the recovery before it's too late, i.e., the recovery has
> completed at the undesirable point. So I think that emitting FATAL is safer.

I included this fix in the patch, which emits FATAL if pause_at_recovery_target
is enabled while hot standby is disabled and the recovery target is set.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment: change_recovery_conf_sample_v3.patch
Description: application/octet-stream (2.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2011-03-08 12:05:08
Subject: Re: Sync Rep v19
Previous:From: Jan UrbaƄskiDate: 2011-03-08 10:11:03
Subject: Re: pl/python tracebacks

pgsql-committers by date

Next:From: User FxjrDate: 2011-03-08 15:50:38
Subject: npgsql - Npgsql2: Fixed problems with SSPI authentication when the
Previous:From: Michael MeskesDate: 2011-03-08 10:28:33
Subject: pgsql: Added new version of ecpg's parser test script which waswritten

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group