Skip site navigation (1) Skip section navigation (2)

Re: pgAdmin III commit: Revert the previous change that introduced sysSetti

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Date: 2011-02-18 16:46:53
Message-ID: AANLkTi=vWdo5Eu+oY8NWJQD498qCFL1_3a6bvqRoZWJC@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Fri, Feb 18, 2011 at 2:47 PM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
> On 17 February 2011 19:28, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> No objections to that, but it does need to handle interoperability
>> with older versions too. IOW, it needs to read/write booleans as
>> REG_SZ values of "true" or "false", not REG_DWORDS. There may be other
>> gotchas too - that's the one I was hitting though.
>
> What about the Read() overloads? They currently work by passing a
> variable by reference (in the C sense, by pointer), to an overload of
> read. ISTM that it would be preferable to have variants with different
> names that return variables by value. What do you think?

I'm not sure that helps - the issue is that the current code reads the
string "true" and treats it as a boolean. What we need to do is ensure
we always write booleans as strings, otherwise it won't be backwards
compatible. Then, ReadBool() just reads a string value, and converts
it.

> By the way, this isn't that much trouble. I've already finished with
> the write() overloads. We're mostly using the inline wrapper functions
> in sysSettings.

OK.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2011-02-18 16:48:57
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Previous:From: Peter GeogheganDate: 2011-02-18 14:50:34
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group