Skip site navigation (1) Skip section navigation (2)

Re: log_checkpoints and restartpoint

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: log_checkpoints and restartpoint
Date: 2011-01-30 20:17:13
Message-ID: AANLkTi=vPPe-hAOm4yX5OOvEYvqf8kFBCrFtn4SiEann@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, Jan 25, 2011 at 11:14 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> When log_checkpoints is enabled, checkpoint logs the number of
> WAL files created/deleted/recycled, but restartpoint doesn't.
> This is OK before 9.0 because restartpoint had never created/
> deleted/recycled WAL files. But, in 9.0 or later, restartpoint might
> do that while walreceiver is running. So I think that it's useful to
> log those numbers even in restartpoint in the now.
>
> The attached patch changes LogCheckpointEnd so that it logs
> the number of WAL files created/deleted/recycled even in
> restartpoint.
>
> And I found the problem about the initialization of CheckpointStats
> struct. The attached patch also fixes this.

This patch looks good to me.  For now, I'm marking it Ready for
Committer.  Absent objections, I will also commit it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2011-01-30 20:21:19
Subject: Re: Add ENCODING option to COPY
Previous:From: Robert HaasDate: 2011-01-30 20:09:20
Subject: Re: [PERFORM] pgbench to the MAXINT

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group