Skip site navigation (1) Skip section navigation (2)

Bug in parse_basebackup_options Re: [COMMITTERS] pgsql: Make walsender options order-independent

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Bug in parse_basebackup_options Re: [COMMITTERS] pgsql: Make walsender options order-independent
Date: 2011-01-25 09:32:11
Message-ID: AANLkTi=udLRSu8gEr9J+q9=KzF-Tra+rHWJbthS9w1Oi@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Jan 24, 2011 at 7:41 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Make walsender options order-independent
>
> While doing this, also move base backup options into
> a struct instead of increasing the number of parameters
> to multiple functions for each new option.

When I read the include-WAL-in-backup patch, I found that this
commit had the bug; parse_basebackup_options fails in parsing
options because of wrong usage of MemSet. Here is the patch.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment: parse_basebackup_options_bugfix_v1.patch
Description: application/octet-stream (541 bytes)

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2011-01-25 09:51:01
Subject: Re: Bug in parse_basebackup_options Re: [COMMITTERS] pgsql: Make walsender options order-independent
Previous:From: Jeff DavisDate: 2011-01-25 09:07:39
Subject: Re: SSI patch version 14

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group