On Tue, Feb 8, 2011 at 10:33, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
> On Tue, Feb 8, 2011 at 08:18, Alexey Klyukin <alexk(at)commandprompt(dot)com> wrote:
>> Thanks, looks great to me. It passes all the tests on my OS X system. I wonder
>> what's the purpose of the amagic_call in get_perl_array_ref, instead of
>> calling newRV_noinc on the target SV * ?
> Well, you can't AV *av = (AV *)SvRV(sv); And the SV * amagic_call
> returns is already a reference, so the newRV_noinc() would be
> redundant no? It occurs to me instead of doing the amagic_call we
> could just call the to_array method directly using perl_call_pv().
> That would look more normal and less magic-- thats probably a good
Err, even simpler would be to just access the 'array' member directly
out of the hash object.
In response to
pgsql-hackers by date
|Next:||From: Dan Ports||Date: 2011-02-08 18:34:46|
|Subject: Re: SSI patch version 14|
|Previous:||From: Simon Riggs||Date: 2011-02-08 18:30:55|
|Subject: pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,|