Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds
Date: 2011-01-09 16:35:28
Message-ID: AANLkTi=gBgWHQOfP14eWsSm3-vKANxymwr1qj3Nrw-qB@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Sun, Jan 9, 2011 at 17:31, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Properly install gram.h on MSVC builds
>> This file is now needed by pgAdmin builds, which started
>> failing since it was missing in the installer builds.
>
> I'd like to protest this patch as misguided.  AFAICS it is a *seriously*

Uh, we install the file on Unix, so we should do the same on Windows.


> bad idea for pgAdmin to be including gram.h --- we don't even want most
> of the backend to include that, let alone external pieces of code.  It's
> not stable enough.  See the note in gramparse.h.

Whether that's misguided is another thing :-)


> To my way of thinking, not installing that file is a fine idea.
> What we really need to be asking is why the pgAdmin folks think
> they should be including it.

It is required in order to pull kwlist.h, which is used to determine
which keywords to highlight in the SQL editor (and other places that
do syntax highlighting). It never actually uses the values, but it
needs the file for kwlist.h to compile.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-01-09 16:49:00
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds
Previous:From: Tom LaneDate: 2011-01-09 16:31:38
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds

pgsql-committers by date

Next:From: Tom LaneDate: 2011-01-09 16:49:00
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds
Previous:From: Tom LaneDate: 2011-01-09 16:31:38
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group