From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Issue with libpq < 8.4 |
Date: | 2010-08-24 11:48:53 |
Message-ID: | AANLkTi=e206Co6gGC=Bami14zjaJ-hAK4gf_RGc_KYNg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Tue, Aug 24, 2010 at 1:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Tue, Aug 24, 2010 at 12:41 PM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
>> So can't we do something like:
>>
>> #ifdef HAVE_CONNINFO_PARSE
>> if (conninfoparse_shows_we_have_application_name_support)
>> use connstr_with_appname;
>> else
>> use connstr_without_appname;
>> #else
>> use connstr_without_appname
>> #endif
>>
>> ? That way it should still work with older libpq, just not set
>> application_name...
>
> That would probably work. We should probably have a runtime check for
> Windows, as we do for the EDB libpq functions.
Yeah, that's probably a good idea.
Actually, what happens if we try to use PQconnect() with
applicaiton_name on an older version? I assume it fails, and not just
works and ignores it?
> When can I expect the patch?
What's with you edb folks, trying to get me to write your patches?
Yesterday Haas, today you... Shall I expect a mail from Ed?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2010-08-24 11:51:03 | Re: Issue with libpq < 8.4 |
Previous Message | Dave Page | 2010-08-24 11:45:50 | Re: Issue with libpq < 8.4 |