Skip site navigation (1) Skip section navigation (2)

Re: pg_execute_from_file review

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Joshua Tolley <eggyknap(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_execute_from_file review
Date: 2010-11-29 15:51:43
Message-ID: AANLkTi=dVG7wwVodKSop80cv5jkDh0dbBZ=qL8YfZZc3@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Nov 29, 2010 at 10:37 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 11/29/2010 10:30 AM, Robert Haas wrote:
>>
>> On Mon, Nov 29, 2010 at 10:27 AM, Robert Haas<robertmhaas(at)gmail(dot)com>
>>  wrote:
>>>
>>> On Mon, Nov 29, 2010 at 4:26 AM, Dimitri Fontaine
>>> <dimitri(at)2ndquadrant(dot)fr>  wrote:
>>>>>
>>>>> * I'd like to ask native speakers whether "from" is needed in names
>>>>>   of "pg_execute_from_file" and "pg_execute_from_query_string".
>>>>
>>>> Fair enough, will wait for some comments before producing a v6.
>>>
>>> Yes, you need the from there.
>>
>> Eh, wait.  You definitely need from in pg_execute_from_file().  But
>> pg_execute_from_query_string() doesn't sound quite right.  What does
>> that function do, anyway?
>
> I'm not sure why you need either "from". It just seems like a noise word.
> Maybe we could use pg_execute_query_file() and pg_execute_query_string(),
> which would be fairly clear and nicely symmetrical.

Because you execute queries, not files.  Or at least that's how I
think about it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-11-29 15:52:44
Subject: Re: Report: Linux huge pages with Postgres
Previous:From: Robert HaasDate: 2010-11-29 15:50:17
Subject: Re: [GENERAL] column-level update privs + lock table

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group