From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: multiset patch review |
Date: | 2011-02-16 15:38:43 |
Message-ID: | AANLkTi=crjK=xzZoFna45Gy-q3+42LRTomQzciTwY85D@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Feb 15, 2011 at 7:13 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Feb 15, 2011 at 4:31 AM, Itagaki Takahiro
> <itagaki(dot)takahiro(at)gmail(dot)com> wrote:
>> array_flatten() no longer exists. I added array_trim() as an alias
>> to trim_array() because it would be a FAQ.
>
> I don't like the alias thing - let's add one name or the other, not both.
>
> Similarly, let's NOT add array_union_all as an alias for array_concat.
>
> 'cannot use multi-dimensional arrays' reads awkwardly to me. I think
> it should say something like "sorting of multi-dimensional arrays is
> not supported".
>
> multi-demensional -> multi-dimensional
>
> slaces -> slices
>
> The formula in the trim_array comment is apparently misparenthesized.
I think we're out of time to keep bikeshedding this. Let's revisit it for 9.2.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-02-16 15:40:31 | Re: [PERFORM] pgbench to the MAXINT |
Previous Message | Robert Haas | 2011-02-16 15:36:53 | Re: [HACKERS] reviewers needed! |