Skip site navigation (1) Skip section navigation (2)

Re: add label to enum syntax

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add label to enum syntax
Date: 2010-10-25 20:03:56
Message-ID: AANLkTi=_vbTaE2V5Za3+MujNDjJ0HYaQBUk0_E0gA9i_@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2010/10/25 Andrew Dunstan <andrew(at)dunslane(dot)net>:
>
>
> On 10/25/2010 02:51 PM, Robert Haas wrote:
>>
>> On Mon, Oct 25, 2010 at 2:41 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us>  wrote:
>>>
>>> "David E. Wheeler"<david(at)kineticode(dot)com>  writes:
>>>>
>>>> On Oct 25, 2010, at 10:08 AM, Tom Lane wrote:
>>>>>
>>>>> I can see the point of that, but I don't find LABEL to be a
>>>>> particularly
>>>>> great name for the elements of an enum type, and so I'm not in favor of
>>>>> institutionalizing that name in the syntax.  How about ADD VALUE?
>>>>
>>>> So the docs have called them "labels" for quite some time.
>>>
>>> There are some places in the docs that use that term, but there are
>>> others that don't.  In any case, using the term in the SQL syntax
>>> casts it in stone, not silly putty ...
>>
>> Personally, I prefer LABEL.  But I could live with VALUE.
>
> That's roughly my position. It would be consistent with the name we use in
> the catalogs, as well as what's in the docs. I don't think it's as opaque as
> Tom seems to suggest. An enum is pretty much an ordered set of labels. But I
> could certainly live with VALUE if that's the consensus.

I agree with you. There are some better keywords than VALUE - maybe
ELEMENT or just LABEL. I understand if there must be a reserved
keyword - but if not I prefer LABEL too.

Regards

Pavel

>
> cheers
>
> andrew
>
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-10-25 20:09:20
Subject: Re: Floating-point timestamps versus Range Types
Previous:From: David FetterDate: 2010-10-25 20:01:23
Subject: Tab completion for view triggers in psql

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group