On 23 January 2011 14:56, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Hmm. Perhaps the bug is that parser.sh should also update FlexLexer.h?
Hacking a system header and then shipping it without mentioning
anything seems like a bad idea, an idea that would be unlikely to fly.
> Yeah, certainly looks like missing include file(s) somewhere? Thought
> it's weird this has stopped working, since it does work in branch head
> - have you changed some global headers? (there are too many things in
> general that are included in global headers, imho, which may hide
> missing local ones i nsome cases)
Haven't removed any #includes at any point. The following files are
changed from master:
>> The class pgsParser very clearly does not have a member named
>> set_debug_level, so it's hard to argue with that.
> Well, in git head, it's in parser.tab.cc. So it seems bison generated
> it then, and that has changed. The one generated is by Bison 2.3, do
> you have a different verison of that as well? Perhaps it's documented
> in the release notes for that one how this has changed?
I have Bison 2.4.3. Having taken a closer look, I see both the
declaration and definition of that function are in parser.tab.cc and
parset.tab.hh respectively. The declaration is within a #if YYDEBUG
block, so that would account for why the compiler doesn't see it. This
is a debug build, so I wonder why, though we seem to expect the
function to be there in either debug or release builds.
> In principle I'm for incremental commits. Assuming the patch itself is
> ok of course, I haven't actually reviewed anything :-)
By the way, I'm seeing lots of warnings like this:
./dlg/dlgSequence.cpp:114:6: warning: suggest explicit braces to avoid
In response to
pgadmin-hackers by date
|Next:||From: Jean-Michel Pouré - GOOZE||Date: 2011-01-23 18:02:26|
|Subject: SSL certificate connections + smartcard|
|Previous:||From: Magnus Hagander||Date: 2011-01-23 14:56:43|
|Subject: Re: wxWidgets 2.9 build|