Skip site navigation (1) Skip section navigation (2)

Re: wxWidgets 2.9 build

From: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: wxWidgets 2.9 build
Date: 2011-01-23 16:01:54
Message-ID: AANLkTi=WphQeuuyVzGKQ2nsy+njjcd_8hf996o4VqQhH@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On 23 January 2011 14:56, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> Hmm. Perhaps the bug is that parser.sh should also update FlexLexer.h?

Hacking a system header and then shipping it without mentioning
anything seems like a bad idea, an idea that would be unlikely to fly.

> Yeah, certainly looks like missing include file(s) somewhere? Thought
> it's weird this has stopped working, since it does work in branch head
> - have you changed some global headers? (there are too many things in
> general that are included in global headers, imho, which may hide
> missing local ones i nsome cases)

Haven't removed any #includes at any point. The following files are
changed from master:

pgadmin/agent/pgaJob.cpp
pgadmin/ctl/calbox.cpp
pgadmin/ctl/ctlListView.cpp
pgadmin/ctl/ctlSQLBox.cpp
pgadmin/ctl/explainShape.cpp
pgadmin/ctl/timespin.cpp
pgadmin/db/pgConn.cpp
pgadmin/db/pgQueryThread.cpp
pgadmin/debugger/dbgPgConn.cpp
pgadmin/dlg/dlgExtTable.cpp
pgadmin/dlg/dlgSelectConnection.cpp
pgadmin/dlg/dlgView.cpp
pgadmin/frm/events.cpp
pgadmin/frm/frmEditGrid.cpp
pgadmin/frm/frmHbaConfig.cpp
pgadmin/frm/frmHint.cpp
pgadmin/frm/frmMainConfig.cpp
pgadmin/frm/frmPgpassConfig.cpp
pgadmin/frm/frmQuery.cpp
pgadmin/frm/frmReport.cpp
pgadmin/frm/frmStatus.cpp
pgadmin/gqb/gqbGraphSimple.cpp
pgadmin/gqb/gqbView.cpp
pgadmin/include/ctl/calbox.h
pgadmin/include/ctl/ctlListView.h
pgadmin/include/ctl/ctlSQLBox.h
pgadmin/include/pgscript/location.hh
pgadmin/include/pgscript/parser.tab.hh
pgadmin/include/pgscript/position.hh
pgadmin/include/pgscript/stack.hh
pgadmin/include/pgscript/statements/pgsStmt.h
pgadmin/include/utils/sysLogger.h
pgadmin/include/utils/sysSettings.h
pgadmin/pgAdmin3.cpp
pgadmin/pgscript/expressions/pgsCast.cpp
pgadmin/pgscript/generators/pgsDictionaryGen.cpp
pgadmin/pgscript/generators/pgsReferenceGen.cpp
pgadmin/pgscript/generators/pgsRegexGen.cpp
pgadmin/pgscript/lex.pgs.cc
pgadmin/pgscript/parser.sh
pgadmin/pgscript/parser.tab.cc
pgadmin/pgscript/pgsApplication.cpp
pgadmin/pgscript/pgsParser.yy
pgadmin/pgscript/utilities/pgsContext.cpp
pgadmin/pgscript/utilities/pgsDriver.cpp
pgadmin/schema/pgIndex.cpp
pgadmin/schema/pgObject.cpp
pgadmin/schema/pgRole.cpp
pgadmin/slony/dlgRepCluster.cpp
pgadmin/slony/slSet.cpp
pgadmin/utils/csvfiles.cpp
pgadmin/utils/factory.cpp
pgadmin/utils/pgconfig.cpp

>> The class pgsParser very clearly does not have a member named
>> set_debug_level, so it's hard to argue with that.
>
> Well, in git head, it's in parser.tab.cc. So it seems bison generated
> it then, and that has changed. The one generated is by Bison 2.3, do
> you have a different verison of that as well? Perhaps it's documented
> in the release notes for that one how this has changed?

 I have Bison 2.4.3. Having taken a closer look, I see both the
declaration and definition of that function are in parser.tab.cc and
parset.tab.hh respectively. The declaration is within a #if YYDEBUG
block, so that would account for why the compiler doesn't see it. This
is a debug build, so I wonder why, though we seem to expect the
function to be there in either debug or release builds.

> In principle I'm for incremental commits. Assuming the patch itself is
> ok of course, I haven't actually reviewed anything :-)

Okay, good.

By the way, I'm seeing lots of warnings like this:

./dlg/dlgSequence.cpp:114:6: warning: suggest explicit braces to avoid
ambiguous ‘else’

Worth fixing?

-- 
Regards,
Peter Geoghegan

In response to

Responses

pgadmin-hackers by date

Next:From: Jean-Michel Pouré - GOOZEDate: 2011-01-23 18:02:26
Subject: SSL certificate connections + smartcard
Previous:From: Magnus HaganderDate: 2011-01-23 14:56:43
Subject: Re: wxWidgets 2.9 build

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group