Re: memory leaks? using savepoint

On Wed, Dec 22, 2010 at 11:48 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
>> The proposed patch looks very simple. I don't think that applying that
>> patch will cause serious risk.
>
> Maybe so, maybe not, but *it won't get tested* to any meaningful degree
> if it's applied.

Umm.. I don't have good idea about this. Spend a lot time on the review?

>> Unless the bug is fixed, the users who encountered the memory-leak
>> cannot update their postgres to the latest version of 8.3. This would
>> cause more serious situation. And, since psqlODBC frequently issues
>> SAVEPONT and RELEASE SAVEPOINT, this memory-leak is not rare case,
>> I think.
>
> The code's been like that for two years, and nobody's complained before
> now, so it doesn't seem to me to be all that urgent.

When I searched PostgreSQL mailing list archives, I found some related
reports:
http://archives.postgresql.org/pgsql-odbc/2009-05/msg00001.php
http://archives.postgresql.org/pgsql-general/2009-04/msg00728.php

> Furthermore, the
> people you are speaking of likely wouldn't upgrade anyway if they
> haven't done so before now...

Maybe. But, at least around me, software update is not performed
so frequently since it requires the re-test of all related components.
Many users (around me) decides whether to do the update in
consideration of the budget and the influence of the bugs in the
version they currently use.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center