Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Remove useless whitespace at end of lines

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove useless whitespace at end of lines
Date: 2010-11-25 08:46:49
Message-ID: AANLkTi=RKadbUqGSOqCzp+Mfhw2K3=meGDHATA1XwW_1@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Wed, Nov 24, 2010 at 23:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>>>> This was stuck in the moderation queue because of message size limit (30
>>>> kB).  Is it worth increasing that value?
>>>
>>> Evidently we should.  pgindent and copyright-update commits are likely
>>> to be at least this long.
>
>> That's twice a year only - I don't see a big problem moderating those
>> when it happens...
>
> Its not so much the moderation load, as I don't like being blindsided by
> commits that touch everything in sight.  Finding out only when you try
> to do git push (as indeed happened to me just this afternoon because of
> this patch) is annoying.

fair enough. I'm not sure the size limit actually protects us against
anything, so I'm not against increasing it.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Shigeru HANADADate: 2010-11-25 08:51:11
Subject: Re: SQL/MED - file_fdw
Previous:From: Shigeru HANADADate: 2010-11-25 08:12:46
Subject: SQL/MED - postgresql_fdw

pgsql-committers by date

Next:From: Itagaki TakahiroDate: 2010-11-25 11:18:28
Subject: pgsql: Don't raise "identifier will be truncated" messages in dblink
Previous:From: Chang ChaoDate: 2010-11-25 06:40:58
Subject: How strings are sorted by LC_COLLATE specifically?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group