Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chris Travers <chris(at)metatrontech(dot)com>, Cristian Bittel <cbittel(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session
Date: 2010-09-10 07:45:00
Message-ID: AANLkTi=L-kLrXWtETCYxm8XtwkzORnH49hfoDu1rpH5c@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Sep 9, 2010 at 20:23, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Thu, Sep 9, 2010 at 19:48, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> On balance I think I'd suggest an #ifdef WIN32 in CleanupBackend that
>>> made it accept 128 as a "normal exit" case.
>
>> Seems reasonable. I'll whack it around for that - see attached.
>
> Hm, still doesn't log, which I think it should, even for testing
> purposes (how will you know the case occurred?).  Maybe like this:

Agreed, that's better.

>> Dave has a reasonably reproducible test environment. Unforunately it's
>> on 8.3, so this patch will be completely unsafe there (it doesn't have
>> the deadman switch). But hopefully it can be used to see it fixes this
>> problem (while introducing others)h
>
> Sounds like a plan.

Patch is with dave for testing now :-)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Magnus Hagander 2010-09-10 07:46:23 Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session
Previous Message Bruce Momjian 2010-09-10 01:12:05 Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-09-10 07:46:23 Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session
Previous Message Tom Lane 2010-09-10 05:51:58 Re: git: uh-oh