Skip site navigation (1) Skip section navigation (2)

Re: Extensions versus pg_upgrade

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Extensions versus pg_upgrade
Date: 2011-02-09 01:59:02
Message-ID: AANLkTi=Jzhy3U0YC2EFM+vuGGWrJHDS4d3FG9JpYLSBF@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, Feb 8, 2011 at 6:54 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
>> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>>> (I was vaguely imagining that it could share most of the COMMENT
>>> infrastructure --- but haven't looked yet).
>
>> Well the code footprint is quite small already.
>
> Having now looked at it a bit closer, I think the syntax choice is a
> complete wash from an implementation standpoint: either way, we'll have
> a list of bison productions that build AlterObjectExtensionStmt nodes,
> and it goes through the same way after that.  I do think that the
> implementation will be a lot more compact if it relies on the COMMENT
> infrastructure (ie, get_object_address), but that's an independent
> choice.
>
> So really it boils down to which syntax seems more natural and/or easier
> to document.  As I said, I think a centralized ALTER EXTENSION syntax
> has some advantages from the documentation standpoint; but that's not a
> terribly strong argument, especially given that Dimitri has already done
> a patch to document things the other way.
>
> Preferences anyone?

The closest exstant parallel is probably:

ALTER SEQUENCE foo OWNED BY bar;

I think paralleling that would probably be the most SQL-ish thing to
do, but I can't get excited about it.  The ALTER EXTENSION syntax will
be a lot more self-contained, with all of it one part of the grammar
and one part of the documentation.  And you could even allow multiple
objects:

ALTER EXTENSION extension_name ADD object-description [, ...];

Which might be handy.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2011-02-09 02:09:48
Subject: Re: SSI patch version 14
Previous:From: Itagaki TakahiroDate: 2011-02-09 01:55:05
Subject: Re: Error attribution in foreign scans

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group