Skip site navigation (1) Skip section navigation (2)

Re: Ticket 269: Add support for 9.1 ALTER TYPE new syntax for enum

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Ticket 269: Add support for 9.1 ALTER TYPE new syntax for enum
Date: 2010-10-31 07:39:17
Message-ID: AANLkTi=EScCwjAfQN6BbBDFL6nGcN2Fjg9bzW695fWNm@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sun, Oct 31, 2010 at 1:56 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 30/10/2010 10:25, Dave Page a écrit :
>
>> Yeah, that's really nasty. I guess we need split the commands at ;.
>
> Yeah. If it's not between quotes. I don't like it at all, but I don't
> see another way of doing it.
>
>> I guess we should pass a flag down somehow to tell the function that
>> executes the query to do that and then we could also potentially get
>> rid of the double SQL boxes.  I'm not looking at the code, but I
>> suspect that'll be nasty.
>>
>
> We actually aren't required to add such a flag. We can check if the
> query contains "ALTER TYPE", and "ADD AFTER" or "ADD BEFORE".

That's knowledge I'd rather avoid hardwiring into the lower level
machinery here.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-10-31 16:44:14
Subject: Re: Ticket 269: Add support for 9.1 ALTER TYPE new syntax for enum
Previous:From: pgAdmin TracDate: 2010-10-31 06:21:50
Subject: [pgAdmin III] #273: Check the number of rows returned by a query

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group