From:
Alex Hunsaker <badalex(at)gmail(dot)com>
To:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:
Andrew Dunstan <andrew(at)dunslane(dot)net>, Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: why does plperl cache functions using just a bool for is_trigger
Date:
2010-11-02 00:40:00
Message-ID:
AANLkTi=BK6FGvLRpMrC1uZw8hTFACKzn1hgTDGUs_Vr3@mail.gmail.com (view raw or flat )
Thread:
2010-10-24 21:40:25 from Jan Urbański <wulczer(at)wulczer(dot)org>
2010-10-24 22:44:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-24 23:05:29 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-10-24 23:50:03 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-25 00:24:54 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-10-25 01:34:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-25 01:59:18 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-10-31 14:44:41 from Jan Urbański <wulczer(at)wulczer(dot)org>
2010-10-31 15:44:40 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-31 18:00:41 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-10-31 20:40:49 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-10-31 21:17:56 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-10-31 21:24:20 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-01 15:28:39 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-11-01 16:02:20 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-11-01 21:24:03 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-01 22:30:18 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-01 22:59:48 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-11-02 00:40:00 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-03 16:28:42 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-11-03 19:57:59 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-03 20:43:49 from Jan Urbański <wulczer(at)wulczer(dot)org>
2010-11-03 21:06:23 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-03 21:15:21 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2010-11-04 11:20:39 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-11-04 20:28:37 from "David E(dot) Wheeler" <david(at)kineticode(dot)com>
2010-11-04 09:46:10 from Hannu Krosing <hannu(at)2ndQuadrant(dot)com>
2010-11-04 09:54:45 from Hannu Krosing <hannu(at)2ndQuadrant(dot)com>
2010-11-04 17:07:58 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-04 19:43:27 from Hannu Krosing <hannu(at)2ndQuadrant(dot)com>
2010-11-04 20:29:49 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-04 20:31:51 from Alex Hunsaker <badalex(at)gmail(dot)com>
2010-11-05 07:19:07 from Jan Urbański <wulczer(at)wulczer(dot)org>
2010-11-05 14:56:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-11-08 17:36:39 from Greg Stark <gsstark(at)mit(dot)edu>
2010-11-05 16:10:20 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-11-04 13:49:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-hackers
On Mon, Nov 1, 2010 at 16:59, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alex Hunsaker <badalex(at)gmail(dot)com> writes:
>> Speaking of which, pltcl stores the trigger reloid instead of a flag
>> (it also uses tg_reloid in the internal proname). It seems a tad
>> excessive to have one function *per* trigger table.
>
> Surely, removing the internal name's dependency on the istrigger flag is
> wrong. If you're going to maintain separate hash entries at the pltcl
> level, why would you want to risk collisions underneath that?
Good catch. I was basing it off plperl which uses the same proname
for both (sprintf(subname, %s__%u", prodesc->proname, fn_oid)). Its
OK for plperl because when we compile we save a reference to it and
use that directly (more or less). The name does not really matter.
In response to
Responses
pgsql-hackers by date
Next :From: Andres FreundDate: 2010-11-02 00:44:29Subject : Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasonsPrevious :From : Andres FreundDate : 2010-11-02 00:37:43Subject : Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons
