Skip site navigation (1) Skip section navigation (2)

Re: pgAdmin III commit: Revert the previous change that introduced sysSetti

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Date: 2011-02-21 10:47:42
Message-ID: AANLkTi=5gdSe3+2s-6xVDzUpM5c4+OBS7MFdc6B_hx=R@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sat, Feb 19, 2011 at 2:45 AM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
> Attached patch makes changes described to write() variants. What do you think?
>
> I conducted a little test to verify that I correctly changed all call
> sites - implicit casts can be tricky. Once I had finished changing the
> function names and their call sites, I provided an overload of write
> with const wxChar*, complete with implementation/definition. I then
> provided just a declaration of all the old overloads of write(). I
> wanted to see if I got any linker errors. The idea of the wxChar*
> variant (the one with the implementation) is to prevent any
> write(const wxString&, const wxChar*) calls from calling my
> write(bool) declaration, as they prefer that to write(const wxString&,
> const wxString&) . Anyway, none of the old declarations were called,
> and I saw no linker errors.
>
> --
> Regards,
> Peter Geoghegan
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

pgadmin-hackers by date

Next:From: Dave PageDate: 2011-02-21 10:48:24
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Previous:From: Dave PageDate: 2011-02-21 10:47:41
Subject: pgAdmin III commit: Replace the various sysSettings::Write overloadswi

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group